Bug 1185 - wireless Trace hooks for NetAnim
wireless Trace hooks for NetAnim
Status: RESOLVED INVALID
Product: ns-3
Classification: Unclassified
Component: wifi
pre-release
All All
: P5 enhancement
Assigned To: John Abraham
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-09 17:32 UTC by John Abraham
Modified: 2011-07-04 05:32 UTC (History)
5 users (show)

See Also:


Attachments
patch 1 (11.99 KB, patch)
2011-06-23 10:53 UTC, John Abraham
Details | Diff
revised patch (4.58 KB, patch)
2011-06-30 16:37 UTC, John Abraham
Details | Diff
revised patch (4.58 KB, patch)
2011-06-30 16:44 UTC, John Abraham
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Abraham 2011-06-09 17:32:59 UTC
Wireless Trace hooks for NetAnim
Comment 1 John Abraham 2011-06-23 10:53:43 UTC
Created attachment 1172 [details]
patch 1
Comment 2 John Abraham 2011-06-30 16:37:41 UTC
Created attachment 1180 [details]
revised patch

Much fewer changes
Comment 3 John Abraham 2011-06-30 16:44:35 UTC
Created attachment 1181 [details]
revised patch
Comment 4 Nicola Baldo 2011-07-04 05:31:01 UTC
For the record, I am reporting here the email exchange related to this bug:

On 06/24/2011 05:42 PM, Ruben Merz wrote:
I had a really quick look, and a priori, it looks good to me.
There is a small indentation issue on line 342  of src/wifi/model/wifi-phy.cc 

On 06/30/2011 10:41 PM, John Abraham wrote:
After some better understanding of the trace mechanism,I have replaced 
the current patch with another much smaller patch.
Please look at it when you have time.
(attachment 1181 [details])


On 07/03/2011 03:52 AM, John Abraham wrote:
Hi All,
After further investigation, I was able to achieve the functionality I 
wanted without any diff. So please disregard this bug for now.

broader discussion is needed about a more consistent format for Trace 
sources in PHY and MAC.
At this point, there is inconsistencies in Wifi, Wimax,LTE trace sources 
although they share common types of info such as "Number of receivers 
for a transmission, Tx range calculated for the Tx etc".
So I want to defer any changes for later

Sorry about the inconvenience if any.


On 07/04/2011 09:18 AM, Ruben Merz wrote:
No probs. A more unified trace format for Wifi, Wimax, LTE, etc sounds 
like something we could discuss at a next developer meeting.
Comment 5 Nicola Baldo 2011-07-04 05:32:15 UTC
Closing this bug based on the last comment by John Abraham (patch not needed any more).