Bug 1242 – m_lastRtt in tcp-socket-base.cc is not implemented

Bug 1242 - m_lastRtt in tcp-socket-base.cc is not implemented


Summary:	m_lastRtt in tcp-socket-base.cc is not implemented

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	tcp
Version:	pre-release
Hardware:	All All

Importance:	P5 normal
Assigned To:	Adrian S.-W. Tam

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-08-10 06:15 UTC by John Abraham
Modified:	2011-09-29 13:17 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description John Abraham 2011-08-10 06:15:35 UTC

proposed diff

--- a/src/internet/model/tcp-socket-base.cc     Mon Aug 08 08:33:29 2011 
-0700 
+++ b/src/internet/model/tcp-socket-base.cc     Wed Aug 10 06:00:43 2011 
-0400 
@@ -1453,7 +1453,7 @@ 
   // Use m_rtt for the estimation. Note, RTT of duplicated 
acknowledgement 
   // (which should be ignored) is handled by m_rtt. Once timestamp 
option 
   // is implemented, this function would be more elaborated. 
-  m_rtt->AckSeq (tcpHeader.GetAckNumber () ); 
+  m_lastRtt = m_rtt->AckSeq (tcpHeader.GetAckNumber () ); 
 };

Comment 1 Adrian S.-W. Tam 2011-09-29 13:17:07 UTC

This is valid. This patch shall be accepted.