Bug 1305 – The list of modules built is printed at the end of the waf clean command

Bug 1305 - The list of modules built is printed at the end of the waf clean command


Summary:	The list of modules built is printed at the end of the waf clean command

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	build system
Version:	pre-release
Hardware:	All All

Importance:	P5 normal
Assigned To:	Mitch Watrous

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-11-29 19:28 UTC by Mitch Watrous
Modified:	2013-06-12 11:47 UTC (History)
CC List:	3 users (show)

See Also:

Attachments
Patch for bug 1305 (2.25 KB, patch) 2011-11-30 18:55 UTC, Mitch Watrous	Details \| Diff
Changes to ns-3--dev/wscript file to prevent printing of list of modules built if build command was "clean". (575 bytes, patch) 2013-06-09 03:04 UTC, moijes12	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mitch Watrous 2011-11-29 19:28:01 UTC

The following code in ns-3's top level wscript used to work: 

    if ((not Options.options.run)
        and (not Options.options.pyrun) 
        and ('clean' not in Options.commands)
        and ('distclean' not in Options.commands)
        and ('shell' not in Options.commands)):

because the Options.commands would contain the commands that were entered ("clean" or "disclean" or "shell").

Now, it is just a blank list when you do 

    ./waf shell

The result is that the list of modules built are printed at the end of the waf shell command.

Comment 1 Mitch Watrous 2011-11-30 18:55:17 UTC

Created attachment 1279 [details]
Patch  for bug 1305

It appears that the waf command entered is no longer available to wscript files in the current version of waf.

The attached patch makes

    ./waf shell 

not print the list of modules built, but

    ./waf clean

still does print those lists.

I don't know how to make

    ./waf clean

not print the lists.

Comment 2 Tom Henderson 2011-12-13 09:21:15 UTC

(In reply to comment #1)
> Created attachment 1279 [details]
> Patch  for bug 1305
> 
> It appears that the waf command entered is no longer available to wscript files
> in the current version of waf.
> 
> The attached patch makes
> 
>     ./waf shell 
> 
> not print the list of modules built, but
> 
>     ./waf clean
> 
> still does print those lists.
> 
> I don't know how to make
> 
>     ./waf clean
> 
> not print the lists.


I would like to apply this patch now (works for me) and leave open for the ./waf clean part, if there are no objections.

Comment 3 Gustavo J. A. M. Carneiro 2011-12-13 10:09:03 UTC

Sorry I couldn't help more.  I have to deliver my thesis this month, so I'm hard pressed for time.

The patch looks very reasonable.

Comment 4 Tom Henderson 2011-12-15 00:55:32 UTC

Mitch's patch committed as 2d8eeffe5ea7 fixes ./waf shell problem; leaving open for ./waf clean issue

Comment 5 moijes12 2013-06-09 03:04:27 UTC

Created attachment 1608 [details]
Changes to ns-3--dev/wscript file to prevent printing of list of modules built if build command was "clean".

Comment 6 Tom Henderson 2013-06-12 11:47:16 UTC

fixed in 9823:a22cd11590bd