Bug 1312 – Wrong assert condition in TopologyReader::Link::GetAttribute

Bug 1312 - Wrong assert condition in TopologyReader::Link::GetAttribute


Summary:	Wrong assert condition in TopologyReader::Link::GetAttribute

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	topology-read
Version:	ns-3-dev
Hardware:	All All

Importance:	P5 critical
Assigned To:	Tommaso Pecorella

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-12-12 17:29 UTC by Alex Afanasyev
Modified:	2011-12-12 18:19 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alex Afanasyev 2011-12-12 17:29:46 UTC

There is wrong (opposite) assert condition in topology-reader.cc:136.

The following patch set resolves the problem.  
https://bitbucket.org/cawka/ns-3-dev/changeset/79a7d63e18ed

In addition, the same patch set slightly optimizes method calls that uses std::string as a parameter.

Comment 1 Tommaso Pecorella 2011-12-12 18:18:54 UTC

Thanks for the fix. Applied with changeset 69e782e15f32