Bug 1359 – TCP sockets can not receive ICMP notifications

Bug 1359 - TCP sockets can not receive ICMP notifications


Summary:	TCP sockets can not receive ICMP notifications

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	internet
Version:	ns-3-dev
Hardware:	All All

Importance:	P5 enhancement
Assigned To:	George Riley

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-02-08 16:05 UTC by Tommaso Pecorella
Modified:	2012-09-27 13:33 UTC (History)
CC List:	2 users (show)

See Also:

Attachments
Add TCP functions to receive ICMP notifications from Layer3 (4.48 KB, patch) 2012-03-17 19:02 UTC, Tommaso Pecorella	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tommaso Pecorella 2012-02-08 16:05:58 UTC

TCP sockets can not receive ICMP notifications (useful for applications) due to the missing function(s):

ReceiveIcmp (Ipv4Address icmpSource, uint8_t icmpTtl,
                            uint8_t icmpType, uint8_t icmpCode, uint32_t icmpInfo,
                            Ipv4Address payloadSource,Ipv4Address payloadDestination,
                            const uint8_t payload[8])

I don't know if it's useful to have it, but I don't see why not.

The feature will be more useful for IPv6, in order to properly handle MTU exceeded packets (still to be done tho).

Opening a bug as a proposed enhancement to not forget about it.

T.

Comment 1 Tommaso Pecorella 2012-03-17 19:02:47 UTC

Created attachment 1360 [details]
Add TCP functions to receive ICMP notifications from Layer3

Preliminary support, untested (should work tho).

It's a copy.paste from UDP socket, so if it's bugged this, we have an issue as well,

Comment 2 Brian Swenson 2012-09-27 13:33:25 UTC

Also needed code in tcp-l4-protocol.cc/.h to call these functions. 

Fixed:  9095:8462a1160246