Bug 1385 – Changing visibility of StartApplication and StopApplication method in Application class

Bug 1385 - Changing visibility of StartApplication and StopApplication method in Application class


Summary:	Changing visibility of StartApplication and StopApplication method in Applica...

Status:	RESOLVED WONTFIX

Product:	ns-3
Classification:	Unclassified
Component:	network
Version:	ns-3-dev
Hardware:	All All

Importance:	P5 normal
Assigned To:	ns-bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-02-29 21:33 UTC by Alex Afanasyev
Modified:	2012-04-17 20:40 UTC (History)
CC List:	3 users (show)

See Also:

Attachments
patch (904 bytes, patch) 2012-02-29 21:33 UTC, Alex Afanasyev	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alex Afanasyev 2012-02-29 21:33:10 UTC

When extending Application it can be necessary to override (Start|Stop)Application method, while being able to call base class implementation.

The small patch that I'm attaching solves this problem.

Comment 1 Alex Afanasyev 2012-02-29 21:33:28 UTC

Created attachment 1349 [details]
patch

Comment 2 Tom Henderson 2012-03-05 00:34:32 UTC

(In reply to comment #1)
> Created attachment 1349 [details]
> patch

Looks OK to me; any other comments?

Comment 3 Tommaso Pecorella 2012-03-05 06:59:21 UTC

Same here, +1

T.

Comment 4 Mathieu Lacage 2012-03-19 04:48:14 UTC

The problem with this patch is that it is not ok to sometimes chain up and sometimes not chain up: we must be consistent. I have no problem with chaining up in principle but we should at least make sure that our own subclasses _do_ chain up. Please, update the doc of the base class methods too.

Comment 5 Alex Afanasyev 2012-04-17 20:40:37 UTC

I figured out that there is no reason to do chaining, at least in this case. (Start|Stop)Application don't do anything at all in base class.