Bug 1394 – Minor inconsistency in the walk-through of examples/tutorial/third.cc

Bug 1394 - Minor inconsistency in the walk-through of examples/tutorial/third.cc


Summary:	Minor inconsistency in the walk-through of examples/tutorial/third.cc

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	documentation
Version:	ns-3.13
Hardware:	All All

Importance:	P5 trivial
Assigned To:	Tom Henderson

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-03-18 09:59 UTC by Rohit Agarwal
Modified:	2012-03-20 04:28 UTC (History)
CC List:	2 users (show)

See Also:

Attachments
Patch for tutorial to show the correct include lines for examples/tutorial/third.cc (695 bytes, patch) 2012-03-18 09:59 UTC, Rohit Agarwal	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Rohit Agarwal 2012-03-18 09:59:45 UTC

Created attachment 1362 [details]
Patch for tutorial to show the correct include lines for examples/tutorial/third.cc

The tutorial shows the wrong include lines during the walk-through of the example script examples/tutorial/third.cc

Comment 1 Tommaso Pecorella 2012-03-18 12:40:20 UTC

+1, go ahead... or not.

Also the network topology is outdated. Please fix that as well... and maybe check if the explaining part shall be updated as well.

BTW, this change should go into the portuguese translation as well :P

T.

Comment 2 Rohit Agarwal 2012-03-18 13:15:46 UTC

(In reply to comment #1)
> +1, go ahead... or not.
> 
> Also the network topology is outdated. Please fix that as well... and maybe
> check if the explaining part shall be updated as well.
> 
> BTW, this change should go into the portuguese translation as well :P
> 
> T.

Following the tutorial further, I found some more inconsistencies.

The tutorial says -

"""
We have configured Wifi for all of our STA nodes, and now we need to configure the AP (access point) node. We begin this process by changing the default Attributes of the NqosWifiMacHelper to reflect the requirements of the AP.

mac.SetType ("ns3::ApWifiMac",
"Ssid", SsidValue (ssid),
"BeaconGeneration", BooleanValue (true),
"BeaconInterval", TimeValue (Seconds (2.5)));

In this case, the NqosWifiMacHelper is going to createMAC layers of the “ns3::ApWifiMac”, the latter specifying that a MAC instance configured as an AP should be created, with the helper type implying that the “QosSupported” Attribute should be set to false - disabling 802.11e/WMM-style QoS support at created APs. We set the “Beacon-Generation” Attribute to true and also set an interval between beacons of 2.5 seconds.
"""

But the file examples/tutorial/third.cc only contains the first two lines -

mac.SetType ("ns3::ApWifiMac",
               "Ssid", SsidValue (ssid));


This results in the tcpdump output generated by the file being substantially different than that shown in the tutorial after 2.011767 seconds.

While looking at the history of third.cc, I found that those lines were removed from third.cc while fixing bug 843 (https://www.nsnam.org/bugzilla/﷒0﷓).

I haven't studied wireless networks yet (i.e. I didn't quite understand the discussion on bug 843), so I am not sure if I am the right person to update the explanation.

Comment 3 Tom Henderson 2012-03-18 13:50:50 UTC

I agree and will fix these in the next day or two.

Comment 4 Tom Henderson 2012-03-20 04:28:16 UTC

changesets:  a27e716d01d9 and 279b0a88b82f (tutorial-pt version)