Bug 1439 – Please exclude headers for tests from installation

Bug 1439 - Please exclude headers for tests from installation


Summary:	Please exclude headers for tests from installation

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	lte
Version:	pre-release
Hardware:	All All

Importance:	P5 normal
Assigned To:	Nicola Baldo

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-05-27 17:18 UTC by Vedran Miletić
Modified:	2012-05-29 09:01 UTC (History)
CC List:	3 users (show)

See Also:

Attachments
Patch (1.12 KB, patch) 2012-05-27 17:18 UTC, Vedran Miletić	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Vedran Miletić 2012-05-27 17:18:09 UTC

Created attachment 1402 [details]
Patch

Hi,

modules other than lte don't install headers for tests. It would be great if lte did the same, unless there is a specific reason for doing otherwise.

Comment 1 Vedran Miletić 2012-05-27 17:43:52 UTC

Same comment applies to buildings module:
        'test/buildings-pathloss-test.h',
        'test/buildings-shadowing-test.h',

Comment 2 Vedran Miletić 2012-05-28 12:22:44 UTC

I assume that:
        'test/lte-simple-net-device.h',
        'test/lte-simple-helper.h',
can stay, but other don't seem very useful.

Comment 3 Nicola Baldo 2012-05-28 13:11:53 UTC

Hi Vedran,

I agree that test headers should not be installed unless they are useful for some other module. Also lte-simple-net-device.h and lte-simple-helper.h are not meant to be used outside of the lte module, and if they really were meant to be used, they should be moved to src/lte/model instead.

It seems however that it takes some effort to fix this, because of the many interdependencies among files in src/lte/test, the need to add some forward declarations, etc. I'll be able to work more on this issue tomorrow.

Comment 4 Nicola Baldo 2012-05-29 08:19:52 UTC

changeset:   49d3a0979d43
user:        Nicola Baldo <nbaldo@cttc.es>
date:        Tue May 29 13:56:26 2012 +0200
summary:     fixed Bug 1439 - exclude headers for tests from installation

Comment 5 Vedran Miletić 2012-05-29 09:01:50 UTC

Thanks Nicola.