Bug 1543 - LTE mac scheduler won't compile
LTE mac scheduler won't compile
Status: RESOLVED FIXED
Product: ns-3
Classification: Unclassified
Component: lte
pre-release
All Linux
: P5 blocker
Assigned To: Nicola Baldo
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-03 12:48 UTC by Mitch Watrous
Modified: 2012-12-05 09:53 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mitch Watrous 2012-12-03 12:48:56 UTC
One of the mac schedulers

    /src/lte/model/fdtbfq-ff-mac-scheduler.cc

has uninitialized variables: 

[1427/2008] cxx: src/lte/model/fdtbfq-ff-mac-scheduler.cc -> build/src/lte/model/fdtbfq-ff-mac-scheduler.cc.1.o
../src/lte/model/fdtbfq-ff-mac-scheduler.cc: In member function ‘void ns3::FdTbfqFfMacScheduler::DoSchedDlTriggerReq(const ns3::FfMacSchedSapProvider::SchedDlTriggerReqParameters&)’:
../src/lte/model/fdtbfq-ff-mac-scheduler.cc:575:49: error: ‘lcid’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
../src/lte/model/fdtbfq-ff-mac-scheduler.cc:567:13: error: ‘rlcBufSize’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1plus: all warnings being treated as errors
Waf: Leaving directory `<https://ns-buildmaster.ee.washington.edu:8010/job/daily-fedora-without-valgrind/./label=Fedora-32-17/ws/ns-3-allinone/ns-3-dev/build'>
Build failed
 -> task in 'ns3-lte' failed (exit status 1): 
	{task 167263468: cxx fdtbfq-ff-mac-scheduler.cc -> fdtbfq-ff-mac-scheduler.cc.1.o}
['/usr/lib/ccache/g++', '-O3', '-g', '-Wall', '-Werror', '-march=native', '-Wno-error=deprecated-declarations', '-fstrict-aliasing', '-Wstrict-aliasing', '-fPIC', '-pthread', '-pthread', '-Ibuild', '-I.', '-I/usr/include/gtk-2.0', '-I/usr/lib/gtk-2.0/include', '-I/usr/include/atk-1.0', '-I/usr/include/cairo', '-I/usr/include/gdk-pixbuf-2.0', '-I/usr/include/pango-1.0', '-I/usr/include/glib-2.0', '-I/usr/lib/glib-2.0/include', '-I/usr/include/pixman-1', '-I/usr/include/freetype2', '-I/usr/include/libpng15', '-I/usr/include/libxml2', '-DHAVE_PACKET_H=1', '-DHAVE_DL=1', '-DDL=1', '-DXML2=1', '-DSQLITE3=1', '-DHAVE_IF_TUN_H=1', '../src/lte/model/fdtbfq-ff-mac-scheduler.cc', '-c', '-o', 'src/lte/model/fdtbfq-ff-mac-scheduler.cc.1.o']
Build step 'Execute shell' marked build as failure
Comment 1 Nicola Baldo 2012-12-03 13:24:46 UTC
Do you have a suggestion for how to reproduce these compilation errors? With my  setup they don't show up, and I guess the same happened to Dizhi. In fact just
Dizhi fixed some similar issues in changeset e4545deccc31, after indication from Tom, but probably without actually seeing the error...
Comment 2 Tom Henderson 2012-12-03 13:55:53 UTC
(In reply to comment #1)
> Do you have a suggestion for how to reproduce these compilation errors? With
> my  setup they don't show up, and I guess the same happened to Dizhi. In
> fact just
> Dizhi fixed some similar issues in changeset e4545deccc31, after indication
> from Tom, but probably without actually seeing the error...

These occur when building as optimized (./waf -d optimized).

Dizhi has now fixed all of these, so I think this can be closed.  I'll leave open for now until the buildslaves pass the tests.
Comment 3 Tom Henderson 2012-12-05 09:53:45 UTC
changeset: 38c7ba91b8bd