Bug 1560 – src/mpi/examples/nms-p2p-nix-distributed.cc doesn't compile with clang

Bug 1560 - src/mpi/examples/nms-p2p-nix-distributed.cc doesn't compile with clang


Summary:	src/mpi/examples/nms-p2p-nix-distributed.cc doesn't compile with clang

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	mpi
Version:	ns-3-dev
Hardware:	PC All

Importance:	P5 normal
Assigned To:	Brian Swenson

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-12-19 18:47 UTC by Brian Swenson
Modified:	2013-12-13 16:49 UTC (History)
CC List:	3 users (show)

See Also:

Attachments
patch to change length-fixed array to vector (52.98 KB, patch) 2013-05-17 18:49 UTC, Zeheng Chen	Details \| Diff
Updated patch (5.56 KB, text/plain) 2013-12-13 16:44 UTC, Brian Swenson	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Brian Swenson 2012-12-19 18:47:02 UTC

clang wants all arrays to have const lengths; this eliminates
possibility to use CommandLine to change values in this example. 

Script needs to be rewritten to remove variable-length arrays.  Temporary fix in place for pending release.

Comment 1 Zeheng Chen 2013-05-17 18:49:45 UTC

Created attachment 1600 [details]
patch to change length-fixed array to vector

Apply this to src/mpi/examples/nms-p2p-nix-distributed.cc

-Zeheng Chen

Comment 2 Brian Swenson 2013-12-13 16:44:19 UTC

Created attachment 1735 [details]
Updated patch

Thanks for the patch.  You missed a few instances with NodeContainer and the NetdeviceContainers at the bottom.  Updated.

Comment 3 Brian Swenson 2013-12-13 16:49:56 UTC

10522:fc88dcae9999