Bugzilla – Bug 1581
Some Click macros or defines are not being defined properly
Last modified: 2013-03-31 15:57:07 UTC
The recent changes to click: Sascha Alexander Allow Click defines to be handled from ns-3 Sascha Alexander Allow Click to pull random numbers from ns-3 caused the following errors on the Ubuntu-64, Fedora-64, and osx-mlion ns-3 automatred build bots: ../src/click/model/ipv4-click-routing.cc: In function ‘int simclick_sim_command(simclick_node_t*, int, ...)’: ../src/click/model/ipv4-click-routing.cc:628: error: ‘SIMCLICK_GET_DEFINES’ was not declared in this scope ../src/click/model/ipv4-click-routing.cc:761: error: ‘SIMCLICK_GET_RANDOM_INT’ was not declared in this scope ../src/click/model/ipv4-click-routing.cc:772: error: ‘SIMCLICK_GET_DEFINES’ was not declared in this scope Waf: Leaving directory `<https://ns-buildmaster.ee.washington.edu:8010/job/daily-ubuntu-without-valgrind/./label=Ubuntu-64-10.04/ws/ns-3-allinone/ns-3-dev/build'> Build failed
(In reply to comment #0) > The recent changes to click: > > Sascha Alexander Allow Click defines to be handled from ns-3 > Sascha Alexander Allow Click to pull random numbers from ns-3 > > caused the following errors on the Ubuntu-64, Fedora-64, and osx-mlion ns-3 > automatred build bots: > > ../src/click/model/ipv4-click-routing.cc: In function ‘int > simclick_sim_command(simclick_node_t*, int, ...)’: > ../src/click/model/ipv4-click-routing.cc:628: error: ‘SIMCLICK_GET_DEFINES’ > was not declared in this scope > ../src/click/model/ipv4-click-routing.cc:761: error: > ‘SIMCLICK_GET_RANDOM_INT’ was not declared in this scope > ../src/click/model/ipv4-click-routing.cc:772: error: ‘SIMCLICK_GET_DEFINES’ > was not declared in this scope > Waf: Leaving directory > `<https://ns-buildmaster.ee.washington.edu:8010/job/daily-ubuntu-without- > valgrind/./label=Ubuntu-64-10.04/ws/ns-3-allinone/ns-3-dev/build'> > Build failed Is the latest revision of Click being used? It won't work otherwise.
> > Is the latest revision of Click being used? It won't work otherwise. I looked into this and found that this requires use of the tip of the click repository: https://github.com/kohler/click/commit/8c07428e803998b0d58fda9ba422b0725c870efc Is click going to make a new release soon? If not, we'll have to find another way to support this if we include this code in ns-3, such as conditional inclusion of these constants depending on click version. As this is -dev code, I don't mind deprecating click-2.0.1 and updating the buildslaves to use click development code, but we should, in that case, change the documentation for ns-3-dev (src/click/doc/click.rst). Sascha and Lalith, thoughts on the above?
(In reply to comment #2) > > > > Is the latest revision of Click being used? It won't work otherwise. > > I looked into this and found that this requires use of the tip of the click > repository: > https://github.com/kohler/click/commit/ > 8c07428e803998b0d58fda9ba422b0725c870efc > > Is click going to make a new release soon? If not, we'll have to find > another way to support this if we include this code in ns-3, such as > conditional inclusion of these constants depending on click version. > > As this is -dev code, I don't mind deprecating click-2.0.1 and updating the > buildslaves to use click development code, but we should, in that case, > change the documentation for ns-3-dev (src/click/doc/click.rst). > > Sascha and Lalith, thoughts on the above? Most Click users use the development version of Click anyway because Click makes releases very infrequently. In any case, there is a new release of Click coming soon and these patches were merged for inclusion into that. So I'd go with deprecating support for Click-2.0.1. I'll update the Click documentation to reflect this.