Bug 1595 - Function declarations without implentations cause problems with the dsr module's Python bindings
Function declarations without implentations cause problems with the dsr modul...
Status: RESOLVED FIXED
Product: ns-3
Classification: Unclassified
Component: dsr
pre-release
All All
: P5 normal
Assigned To: ns-bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-22 13:09 UTC by Mitch Watrous
Modified: 2013-06-02 12:38 UTC (History)
1 user (show)

See Also:


Attachments
Patch to remove unimplemented functions from dsr module (4.97 KB, patch)
2013-02-22 13:09 UTC, Mitch Watrous
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mitch Watrous 2013-02-22 13:09:27 UTC
Created attachment 1523 [details]
Patch to remove unimplemented functions from dsr module

There are many functions in the dsr module that are declared in their class's header file (.h) but are not present in the class's implementation file (.cc).

This causes problems for the dsr module's Python bindings when they are included into a Python program.

The attached patch removes those function declarations.

Note that after the patch is applied, the Python bindings for the dsr module will need to rescanned and committed before the bug can be closed.

You can test that the new bindings are good by importing the dsr module in a Python script like first.py:

import ns.dsr

The above statement should work once the patch has been applied and the new bindings have been rescanned.
Comment 1 Mitch Watrous 2013-03-11 19:55:23 UTC
Bug closed.

ns-3-dev changeset:  17e4f195109b
Comment 2 Tom Henderson 2013-05-29 19:08:21 UTC
some of these unimplemented functions crept back in since this was committed
Comment 3 Tom Henderson 2013-06-02 12:38:05 UTC
fixed again in changeset 9821:c5b83fec4d30