Bug 163 – tcp default attributes should not be prefixed with Tcp

Bug 163 - tcp default attributes should not be prefixed with Tcp


Summary:	tcp default attributes should not be prefixed with Tcp

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	internet
Version:	pre-release
Hardware:	All All

Importance:	P3 normal
Assigned To:	ns-bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-04-08 16:57 UTC by Mathieu Lacage
Modified:	2008-07-01 13:32 UTC (History)
CC List:	0 users

See Also:

Attachments
Patch to fix the issue (3.97 KB, patch) 2008-04-10 15:30 UTC, Rajib Bhattacharjea	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mathieu Lacage 2008-04-08 16:57:40 UTC

Attributes are local to the class they are defined in so, there is no need to add a class-specific prefix. This makes the 'long' attribute name more painful than it need to. i.e., for now, I have to type Config::SetDefault ("ns3::Tcp::TcpDefaultDelAckDelay", Double (0.4));

Comment 1 Rajib Bhattacharjea 2008-04-10 15:30:30 UTC

Created attachment 124 [details]
Patch to fix the issue

This is the fix, but I can't figure out if this sets off a regression (no way it should but, since my system claims a regression already...).  Can someone else patch and verify, then push?

Comment 2 Rajib Bhattacharjea 2008-04-11 13:05:22 UTC

Fixed in ns-3-dev
2904:413ef952ea19