Bug 1662 – m_type not set for Ipv6OptionRouterAlertHeader in file 'ipv6-option-header.cc'

Bug 1662 - m_type not set for Ipv6OptionRouterAlertHeader in file 'ipv6-option-header.cc'


Summary:	m_type not set for Ipv6OptionRouterAlertHeader in file 'ipv6-option-header.cc'

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	ipv6
Version:	ns-3-dev
Hardware:	All All

Importance:	P5 normal
Assigned To:	Tommaso Pecorella

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-04-29 07:03 UTC by francisco javier sanchez-roselly
Modified:	2013-05-17 07:47 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
packed diff file solving the bug (948 bytes, application/zip) 2013-04-29 07:03 UTC, francisco javier sanchez-roselly	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description francisco javier sanchez-roselly 2013-04-29 07:03:15 UTC

Created attachment 1581 [details]
packed diff file solving the bug

In file 'ipv6-option-header.cc', for Ipv6OptionRouterAlertHeader constructor, m_type is not set, i.e. there is no call to SetType() method. This implies that the mentioned option has the same m_type as Pad1.

A sample application will be provided to reproduce this bug.

An IPv6 packet containing a Router Alert Option Header is not properly parsed in Wireshark. Router Alert Option is decoded as Pad1 Option; Headers and/or Payload following get misaligned. 

Router Alert Option must have its type set as 5 in Ipv6OptionRouterAlertHeader::Ipv6OptionRouterAlertHeader() included in ipv6-option-header.cc

Changeset 9715:90e0789f7951

Build 2013-04-25 on Linux 3.7.9-gentoo

Comment 1 Tommaso Pecorella 2013-05-17 07:47:32 UTC

Fixed in changeset 9761 - 32e15e895529