Bug 1674 – LTE bindings need rescan and small refactoring of LTE module source code

Bug 1674 - LTE bindings need rescan and small refactoring of LTE module source code


Summary:	LTE bindings need rescan and small refactoring of LTE module source code

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	lte
Version:	ns-3-dev
Hardware:	All All

Importance:	P1 blocker
Assigned To:	Nicola Baldo

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-05-06 01:45 UTC by Alex Afanasyev
Modified:	2013-05-10 02:16 UTC (History)
CC List:	3 users (show)

See Also:

Attachments
commenting out unimplemented methods (2.69 KB, application/octet-stream) 2013-05-06 01:45 UTC, Alex Afanasyev	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alex Afanasyev 2013-05-06 01:45:26 UTC

Created attachment 1591 [details]
commenting out unimplemented methods

Some methods within LTE module are unimplemented:
- EpcSgwPgwApplication::ActivateS1Bearer  in src/lte/model/epc-sgw-pgw-application.h

- RadioBearerStatsConnector::FindImsiFromEnbRlcPath, FindCellIdFromEnbRlcPath, FindImsiFromUeRlcPath, FindCellIdFromUeRlcPath  in src/lte/model/radio-bearer-stats-connector.h

- EpsBearerTag::GetLayer in src/lte/model/eps-bearer-tag.h

- RrcConnectionReleaseHeader::GetRrcTransactionIdentifier in src/lte/model/lte-rrc-header.h


I could have missed others, but commenting out the listed things (see the attached patch) made possible to import ns.lte module in python (and make visualizer actually work...)

---

There are also several compilation warnings, if compiled with clang++, but this are not critical.

Comment 1 Tom Henderson 2013-05-06 02:00:40 UTC

we should try to address this before release, changing to P1

Comment 2 Nicola Baldo 2013-05-06 12:10:19 UTC

changeset:   9743:2e4aed7f3ea8

I've removed the unimplemented LTE methods instead of commenting them out.
 
Can you please re-check the bindings after this change?

Comment 3 Mitch Watrous 2013-05-06 12:55:15 UTC

I just committed new Python bindings for the LTE module.