Bug 1687 – wscript features report doesn't respect NOCOLOR

Bug 1687 - wscript features report doesn't respect NOCOLOR


Summary:	wscript features report doesn't respect NOCOLOR

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	build system
Version:	ns-3-dev
Hardware:	All All

Importance:	P5 normal
Assigned To:	Gustavo J. A. M. Carneiro

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-05-21 19:54 UTC by Peter Barnes
Modified:	2013-08-14 17:14 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Peter Barnes 2013-05-21 19:54:46 UTC

waf doesn't generate colored output if the environment variable NOCOLOR is non-null.[1]  This is useful when running in environments without a capable terminal.

Commit 2ff57d50b827[2] appears to have broken this behavior for the ns-3 features report generated at the end of the build:

---- Summary of optional NS-3 features:
Python Bindings               : [01;31mnot enabled (disabled by user request)[0m

I can't see where waf checks NOCOLOR, otherwise I'd suggest a patch.

[1] http://code.google.com/p/waf/wiki/EnvironmentVariables
[2] http://code.nsnam.org/ns-3-dev/rev/2ff57d50b827

Comment 1 Peter Barnes 2013-08-14 17:14:52 UTC

Fixed, commit 10147 (52b4fed4e789)