Bugzilla – Bug 1690
Missing header files from wscript
Last modified: 2013-08-16 13:16:00 UTC
The wscript file of wifi module is missing some header files from the list. It was pointed out when simple-wireless-tdma was included that requested ns3/wifi-mac-trailer.h and it was missing. I run a 'find' in the wifi model like this: find . -type f -iname '*.h' and compared the output with the header files in the wscript file. The following are missing: ./bindings/scan-header.h ./model/msdu-standard-aggregator.h ./model/qos-blocked-destinations.h ./model/wifi-mac-trailer.h ./model/wifi-phy-state-helper.h ./model/mac-tx-middle.h ./model/random-stream.h In addition 'model/wifi-phy.h', is twice in that list.
(In reply to comment #0) > The wscript file of wifi module is missing some header files from the list. > > It was pointed out when simple-wireless-tdma was included that requested > ns3/wifi-mac-trailer.h and it was missing. > > I run a 'find' in the wifi model like this: > find . -type f -iname '*.h' > > and compared the output with the header files in the wscript file. > > The following are missing: > > ./bindings/scan-header.h > > ./model/msdu-standard-aggregator.h > ./model/qos-blocked-destinations.h > ./model/wifi-mac-trailer.h > ./model/wifi-phy-state-helper.h > ./model/mac-tx-middle.h > ./model/random-stream.h > These exclusions may be by design. Not all headers are intended for the public API of WiFi. Can you confirm that any/all of these are needed by users of the WiFi module? > > In addition 'model/wifi-phy.h', is twice in that list. This can be fixed, I agree.
(In reply to comment #1) > (In reply to comment #0) > > The wscript file of wifi module is missing some header files from the list. > > > > It was pointed out when simple-wireless-tdma was included that requested > > ns3/wifi-mac-trailer.h and it was missing. > > > > I run a 'find' in the wifi model like this: > > find . -type f -iname '*.h' > > > > and compared the output with the header files in the wscript file. > > > > The following are missing: > > > > ./bindings/scan-header.h > > > > ./model/msdu-standard-aggregator.h > > ./model/qos-blocked-destinations.h > > ./model/wifi-mac-trailer.h > > ./model/wifi-phy-state-helper.h > > ./model/mac-tx-middle.h > > ./model/random-stream.h > > > > These exclusions may be by design. Not all headers are intended for the public > API of WiFi. Can you confirm that any/all of these are needed by users of the > WiFi module? > At least the wifi-mac-trailer is used from simple-wireless-tdma and that's why I started looking into these headers. The phy-state-helper also seems useful with those trace sources about Tx/Rx that could be used from other modules or simulation scripts for wifi-state analysis. > > > > In addition 'model/wifi-phy.h', is twice in that list. > > > This can be fixed, I agree.
changeset 35694ab6581e