Bug 1734 – [PATCH] TcpSocketBase produces spurious delayed ACKs

Bug 1734 - [PATCH] TcpSocketBase produces spurious delayed ACKs


Summary:	[PATCH] TcpSocketBase produces spurious delayed ACKs

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	internet
Version:	ns-3-dev
Hardware:	All All

Importance:	P5 normal
Assigned To:	George Riley

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-07-17 01:06 UTC by Lawrence Stewart
Modified:	2015-02-01 16:33 UTC (History)
CC List:	3 users (show)

See Also:

Attachments
Patch which cancels the delayed ACK timer event when sending ACK-laden data packets. (1.10 KB, application/octet-stream) 2013-07-17 01:06 UTC, Lawrence Stewart	Details
updated patch (710 bytes, patch) 2015-02-01 06:03 UTC, Tommaso Pecorella	Details \| Diff
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lawrence Stewart 2013-07-17 01:06:54 UTC

Created attachment 1641 [details]
Patch which cancels the delayed ACK timer event when sending ACK-laden data packets.

TcpSocketBase doesn't cancel the delayed ACK timer event when sending a data packet that contains an ACK, which can result in spurious delayed ACKs being sent. Attached patch fixes the issue for me.

Comment 1 Tommaso Pecorella 2015-02-01 06:03:11 UTC

Created attachment 1967 [details]
updated patch

+1 from my side.
All tests passed.

Comment 2 Tommaso Pecorella 2015-02-01 16:33:20 UTC

changeset 11202:6286a5dc3f64