Bug 1778 – TapBridge linkUp notification patch

Bug 1778 - TapBridge linkUp notification patch


Summary:	TapBridge linkUp notification patch

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	tap-bridge
Version:	pre-release
Hardware:	PC Linux

Importance:	P5 enhancement
Assigned To:	Tom Goff

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-10-20 09:46 UTC by Tom Henderson
Modified:	2013-11-19 12:35 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
Modified patch (1.77 KB, patch) 2013-10-27 23:01 UTC, Tom Goff	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tom Henderson 2013-10-20 09:46:00 UTC

From Piotr Jurkiewicz's email to ns-developers:

This patch simply implements TapBridge::IsLinkUp() function, which has been originally left unimplemented (it was always returning true).

Code mostly follows approach from FdNetDevice. Device status is set to "up" after ns-3 connects to the tap interface.

Code:
http://gist.github.com/piotrjurkiewicz/6067864

Comment 1 Tom Goff 2013-10-27 23:01:43 UTC

Created attachment 1691 [details]
Modified patch

The proposed patch looks good.  I suggest the following minor changes
included in the attached patch:

 - call NotifyLinkUp() from StartTapDevice() instead of CreateTap()

 - tweak NotifyLinkUp() to add logging and check if the link is
   already up

Comment 2 Tom Henderson 2013-11-19 12:35:43 UTC

pushed in changeset 10433:bfeee916e7c5