Bug 1789 – missing test condition for sigma in buildings-shadowing-test

Bug 1789 - missing test condition for sigma in buildings-shadowing-test


Summary:	missing test condition for sigma in buildings-shadowing-test

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	buildings
Version:	pre-release
Hardware:	PC Mac OS

Importance:	P5 normal
Assigned To:	Nicola Baldo

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-11-06 01:48 UTC by Tom Henderson
Modified:	2013-12-12 12:55 UTC (History)
CC List:	2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tom Henderson 2013-11-06 01:48:38 UTC

found in static, optimized build on OS X with Xcode 5.0.1:

[1273/1959] cxx: src/buildings/test/buildings-shadowing-test.cc -> build/src/buildings/test/buildings-shadowing-test.cc.3.o
In file included from ../src/buildings/test/buildings-shadowing-test.cc:34:
../src/buildings/test/buildings-shadowing-test.h:53:10: error: private field 'm_sigmaRef' is not used [-Werror,-Wunused-private-field]
  double m_sigmaRef;
         ^
1 error generated.

Comment 1 Nicola Baldo 2013-11-07 13:27:14 UTC

I get the impression that we actually miss one test condition about sigma here.
Marco do you have any comment?

Comment 2 Nicola Baldo 2013-12-12 12:55:59 UTC

I had to revert part of change 10436 since it deleted some code and reference values that were actually needed.


changeset:   10507:b8b49ec8f898
user:        Nicola Baldo <nbaldo@cttc.es>
date:        Thu Dec 12 16:55:56 2013 +0100
summary:     reverted change 10436 for src/buildings

changeset:   10508:e03b086478eb
user:        Nicola Baldo <nbaldo@cttc.es>
date:        Thu Dec 12 17:00:09 2013 +0100
summary:     remove unneeded include

changeset:   10510:34299825e664
parent:      10508:e03b086478eb
user:        Nicola Baldo <nbaldo@cttc.es>
date:        Thu Dec 12 18:50:12 2013 +0100
summary:     Bug 1789 - missing test condition for sigma in buildings-shadowing-test

changeset:   10511:3df0e5c2eed5
tag:         tip
parent:      10510:34299825e664
parent:      10509:2081aa152526
user:        Nicola Baldo <nbaldo@cttc.es>
date:        Thu Dec 12 18:50:20 2013 +0100
summary:     merge