Bug 1872 – Inside RREQ processing, in case of IP duplication, packet dropped instead of being forwarded

Bug 1872 - Inside RREQ processing, in case of IP duplication, packet dropped instead of being forwarded


Summary:	Inside RREQ processing, in case of IP duplication, packet dropped instead of ...

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	dsr
Version:	ns-3-dev
Hardware:	All All

Importance:	P3 normal
Assigned To:	Yufei Cheng

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-03-06 14:51 UTC by Tomasz Seweryn
Modified:	2014-05-02 10:38 UTC (History)
CC List:	2 users (show)

See Also:

Attachments
Correction for RREQ packet processed improperly in dsr (2.39 KB, patch) 2014-03-06 14:55 UTC, Tomasz Seweryn	Details \| Diff
Final correction (2.57 KB, patch) 2014-03-11 13:10 UTC, Tomasz Seweryn	Details \| Diff
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tomasz Seweryn 2014-03-06 14:51:12 UTC

During RREQ packet processing, in case of a node having route to the destination in its route cache, when there is a duplication of nodes in route collected until current node and route from route cache of current node, a packet is dropped instead of being forwarded.

Proper definition from RFC http://www.ietf.org/rfc/rfc4728.txt in the section 8.2.2. , last bullet on "[Page 68]":
"If the node does not return a cached Route Reply, then this node SHOULD transmit this copy of the packet as a link-layer broadcast (...)". 

In current form, algorithm works not in line with definition.
Proposed fix in the attachment.

Comment 1 Tomasz Seweryn 2014-03-06 14:55:45 UTC

Created attachment 1794 [details]
Correction for RREQ packet processed improperly in dsr

Comment 2 Tomasz Seweryn 2014-03-11 13:10:44 UTC

Created attachment 1799 [details]
Final correction

I'm terribly sorry, but previous bug fix is incorrect. I'm putting a correct one in this attachment.

Comment 3 Tommaso Pecorella 2014-05-02 10:38:43 UTC

changeset:   10774:1f47a73ab755