Bug 1887 – Point-to-point traces should contain PPP headers

Bug 1887 - Point-to-point traces should contain PPP headers


Summary:	Point-to-point traces should contain PPP headers

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	point-to-point
Version:	ns-3.19
Hardware:	All All

Importance:	P5 major
Assigned To:	ns-bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-03-20 12:58 UTC by Eugene Chemeritskiy
Modified:	2014-03-25 16:47 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
provide trace with original packet copy (1.14 KB, application/octet-stream) 2014-03-20 12:58 UTC, Eugene Chemeritskiy	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Eugene Chemeritskiy 2014-03-20 12:58:20 UTC

Created attachment 1805 [details]
provide trace with original packet copy

On packet receive PointToPointNetDevice feeds its trace sources with packets, that do not have a PPP header, while trace sinks expect it to be included.

Comment 1 Tommaso Pecorella 2014-03-20 18:17:08 UTC

Hi,

yes, no, maybe.

These two have to be the "fixed" as well.

  m_snifferTrace (packet);
  m_promiscSnifferTrace (packet);

Comment 2 Tommaso Pecorella 2014-03-25 16:47:08 UTC

Pushed in changeset 10678 cbaefda493be