Bug 1893 – issue in DoSchedUlTriggerReq with harq

Bug 1893 - issue in DoSchedUlTriggerReq with harq


Summary:	issue in DoSchedUlTriggerReq with harq

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	lte
Version:	ns-3.19
Hardware:	PC Linux

Importance:	P5 enhancement
Assigned To:	Nicola Baldo

URL:
Keywords:

Duplicates:	1854 (view as bug list)
Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-04-01 09:28 UTC by Biljana Bojović
Modified:	2014-09-03 07:43 UTC (History)
CC List:	3 users (show)

See Also:

Attachments
diff file (597 bytes, patch) 2014-04-01 09:28 UTC, Biljana Bojović	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Biljana Bojović 2014-04-01 09:28:10 UTC

Created attachment 1810 [details]
diff file

Out of range exception occures in e.g. Round Robin scheduler, "DoSchedUlTriggerReq" function, line 1350:
                  if (rbMap.at (j) == true)


As far as I understand, this is caused by wrong placement of assignement:

rbStart = rbStart + rbLen; in function "DoSchedDlTriggerReq" in line 666.

This assignement should be moved to be after  if (m_harqOn == true){...}. I tried it and tested it and it works fine now.

Comment 1 Nicola Baldo 2014-05-02 11:27:30 UTC

Marco, can you please take a look at this? 
I wonder if there is any relationship with the bug you fixed in changeset 53870483ef76

Comment 2 Nicola Baldo 2014-09-02 12:33:50 UTC

I tried to reproduce this bug with the test program of Bug 1854, and it still failed with the latest ns-3-dev. 

I also tried to apply the patch and in fact it seems to fix the problem, i.e., the previous crash reported in Bug 1854 (and here as well) goes away.

Marco, could you please comment if you think this patch is ok to apply?

Comment 3 Marco Miozzo 2014-09-03 04:40:50 UTC

The patch is fine with me, go ahead.

Comment 4 Nicola Baldo 2014-09-03 07:43:21 UTC

I applied the fix to all the LTE MAC schedulers

changeset:   10879:a9443dfe8b21
tag:         tip
user:        Nicola Baldo <nbaldo@cttc.es>
date:        Wed Sep 03 13:42:12 2014 +0200
summary:     fixed Bug 1893 - issue in DoSchedUlTriggerReq with harq

Thanks Biljana for the fix and Marco for the review!

Comment 5 Nicola Baldo 2014-09-03 07:43:40 UTC

*** Bug 1854 has been marked as a duplicate of this bug. ***