Bug 191 – Application::Start/Stop, time parameter inconsistent with Simulator::Schedule, Simulator::StopAt(time)->Stop(time)

Bug 191 - Application::Start/Stop, time parameter inconsistent with Simulator::Schedule, Simulator::StopAt(time)->Stop(time)


Summary:	Application::Start/Stop, time parameter inconsistent with Simulator::Schedule...

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	core
Version:	pre-release
Hardware:	All All

Importance:	P3 normal
Assigned To:	Gustavo J. A. M. Carneiro

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-05-28 11:28 UTC by Gustavo J. A. M. Carneiro
Modified:	2008-07-01 13:32 UTC (History)
CC List:	0 users

See Also:

Attachments
patch to make all times relative (9.02 KB, patch) 2008-05-28 12:26 UTC, Gustavo J. A. M. Carneiro	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gustavo J. A. M. Carneiro 2008-05-28 11:28:37 UTC

Problem described in the mailing list thread "Application::Start/Stop, time parameter inconsistent with Simulator::Schedule":

http://www.nabble.com/Application::Start-Stop,-time-parameter-inconsistent-with-Simulator::Schedule-td17490805.html

I will cook a patch to make all times relative and remove the At suffixes.

Comment 1 Gustavo J. A. M. Carneiro 2008-05-28 12:26:30 UTC

Created attachment 139 [details]
patch to make all times relative

Comment 2 Mathieu Lacage 2008-05-28 16:09:44 UTC

looks good to me. I assume you reviewed all callers of Application::Start and Stop to verify that they would still work unmodified with the new semantics ?

Comment 3 Gustavo J. A. M. Carneiro 2008-05-29 04:30:18 UTC

(In reply to comment #2)
> looks good to me. I assume you reviewed all callers of Application::Start and
> Stop to verify that they would still work unmodified with the new semantics ?
> 

Yes.  This only affects Start/Stop in the middle of a simulation.  At the start of simulation relative/absolute makes no difference.

Comment 4 Gustavo J. A. M. Carneiro 2008-05-29 06:46:45 UTC

Committed.