Bugzilla – Bug 1939
Aggregating the same object to two nodes produce unexpected results
Last modified: 2016-05-24 18:13:32 UTC
Created attachment 1852 [details] test script This is nasty, and it has been found by Abdulhalim Dandoush <adandoush@gmail.com>. A serendipitous finding, as he didn't recognize the bug. Still, credits to him. When you aggregate an object (in the example case an EnergySource) to more than a node, then funny things happens. An example: installing the Internet stack on one of the nodes will install it in all the others as well. Just... the SAME object. Basically, aggregating the same object to two different nodes will make them have the very same list of aggregated objects, and when you add one object to the first node, then all the other nodes will have it as well. About the resolution: I guess that the easier thing is to just throw an error if an object is aggregated to more than another object. How... dunno yet.
Created attachment 2378 [details] Proposed bugfix
Created attachment 2379 [details] Updated bugfix The original check is not needed anymore, so I amended its removal to my bugfix. The fix just checks that each aggregate of the "other" object can not be reached by doing GetObject on "this" object. Before, the check was performed only on the primary type of the "other" object.
Created attachment 2380 [details] Proposed patch Cleaned up the patch and commit message a bit.
Created attachment 2381 [details] Proposed patch Clarified evermore the error message and updated the commit message to the new "standard" format
Created attachment 2382 [details] Proposed patch Fixed email
Pushet in changeset 12135:046554f2f0fa