Bug 1942 – refactoring of lte-sinr-chunk-processor

Bug 1942 - refactoring of lte-sinr-chunk-processor


Summary:	refactoring of lte-sinr-chunk-processor

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	lte
Version:	ns-3-dev
Hardware:	PC Linux

Importance:	P5 enhancement
Assigned To:	Nicola Baldo

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-07-02 11:19 UTC by Nicola Baldo
Modified:	2014-12-19 10:55 UTC (History)
CC List:	2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Nicola Baldo 2014-07-02 11:19:46 UTC

In src/lte/model/lte-interference.{h,cc}, the "Sinr" in XxxxxSinrChunkProcessor is in many case misnamed as it's not always SINR. The same applies for the m_sumSinr variable in many places, often it's not SINR. 

We should rename variables so the naming is consistent.

Comment 1 Nicola Baldo 2014-07-02 11:21:10 UTC

sorry wrong files, the right ones are lte-sinr-chunk-processor.{h,cc}

Comment 2 Nicola Baldo 2014-07-03 07:40:32 UTC

There is also a lot of copy-paste in these files. It looks like that all this copy-paste is needed just to pass output to functions with different names, but that have all the same signature. Maybe we could refactor it to use a single class with a (list of?) callbacks to which the output is passed.

Comment 3 Nicola Baldo 2014-12-19 10:55:28 UTC

This was fixed by Piotr as part of the GSoC 2014 FFR algorithms work (changeset 3e86fac77082)