Bug 1954 – Serialized size of wifi-net-device differ for TX and RX trace

Bug 1954 - Serialized size of wifi-net-device differ for TX and RX trace


Summary:	Serialized size of wifi-net-device differ for TX and RX trace

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	wifi
Version:	ns-3.20
Hardware:	All All

Importance:	P5 enhancement
Assigned To:	sebastien.deronne

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-07-18 05:32 UTC by Matthias
Modified:	2015-10-10 05:46 UTC (History)
CC List:	2 users (show)

See Also:

Attachments
diff -r da0eb48df23f src/wifi/model/wifi-net-device.cc (908 bytes, text/plain) 2014-07-18 05:32 UTC, Matthias	Details
refactored patch (1.08 KB, patch) 2015-10-04 16:43 UTC, sebastien.deronne	Details \| Diff
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Matthias 2014-07-18 05:32:04 UTC

Created attachment 1855 [details]
diff -r da0eb48df23f src/wifi/model/wifi-net-device.cc

I wondered why the packet sizes for one packet differ for MacTx and MacRx trace of the WifiMac-Class. The reason is, that the Notification is done at "sender"-Side after adding the LLC-Header to the Packet and at "receiver"-Side after removing it. Actually the header should be removed after notifiying the LLC-Packet at receiver side. I attached a example patch for solving this issue.

Comment 1 sebastien.deronne 2015-10-04 16:43:55 UTC

Created attachment 2159 [details]
refactored patch

The order of operation is indeed not ok.
But I do not fully agree with the patch, llc header may be removed twice.

I changed a bit the proposed patch.

Comment 2 sebastien.deronne 2015-10-10 05:46:52 UTC

refactored patch committed in changeset 11686:aa661e60709e