Bug 2008 – crash if ending rx while status change is in progress

Bug 2008 - crash if ending rx while status change is in progress


Summary:	crash if ending rx while status change is in progress

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	lr-wpan
Version:	ns-3-dev
Hardware:	PC Linux

Importance:	P5 major
Assigned To:	Tom Henderson

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-10-15 16:33 UTC by Luca Dariz
Modified:	2015-05-02 16:24 UTC (History)
CC List:	3 users (show)

See Also:

Attachments
simple test case (2.63 KB, text/x-c++src) 2014-10-15 16:33 UTC, Luca Dariz	Details
possible bugfix (1.48 KB, patch) 2014-10-15 18:39 UTC, Tommaso Pecorella	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Luca Dariz 2014-10-15 16:33:31 UTC

Created attachment 1903 [details]
simple test case

When receiving more than one packet (collision), if at the moment of receiving the second packet a state change is in progress the simulator will crash, as the currentRxParams have been cleared and the state is still BUSY_RX.
I attach a test case able to reproduce the bug, I am not sure how this case should be handled.

Comment 1 Tommaso Pecorella 2014-10-15 18:39:24 UTC

Created attachment 1905 [details]
possible bugfix

The patch is untested. No, it's tested. MAYBE it's tested.
The tests are passing, almost. I had to "fix" one of them (the collision one) because in one specific sub-clause one packet is now received, and before none was received.

Comment 2 Luca Dariz 2014-10-16 06:14:04 UTC

Hi Tommaso, 
thank you, this patch works also for my simulation.

Comment 3 Tommaso Pecorella 2015-05-02 16:24:09 UTC

changeset 11346	a8900f6fe42d