Bug 2109 – Comments of GetPreqReceivers

Bug 2109 - Comments of GetPreqReceivers


Summary:	Comments of GetPreqReceivers

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	mesh
Version:	ns-3.22
Hardware:	All All

Importance:	P5 normal
Assigned To:	ns-bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2015-05-01 22:42 UTC by whimsyduke
Modified:	2015-05-05 22:57 UTC (History)
CC List:	3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description whimsyduke 2015-05-01 22:42:01 UTC

The Comments GetPreqReceivers() function may be error.

It is at line 159-160 in src/mesh/model/dot11s/hwmp-protocol.h

  /// \return list of addresses where a PERR should be sent to
  std::vector<Mac48Address> GetPreqReceivers (uint32_t interface);

I think it should return the list of addresses where a PREQ should be sent to, not the PERR, and the function for PERR is GetPerrReceivers() in line 156-157.

Also, the error can be find in https://www.nsnam.org/docs/release/3.22/doxygen/classns3_1_1dot11s_1_1_hwmp_protocol.html#a0983e62bfc5f01daccfe09d04208c297

Comment 1 whimsyduke 2015-05-05 20:48:03 UTC

This error also in the mesh module, after 11366 for making 802.11s model more compliant to the IEEE802.11s-2012 standard.

Comment 2 Tom Henderson 2015-05-05 22:57:31 UTC

fixed in changeset 11381:f31f1eb1cc99; thanks for reporting