Bug 2114 – Compiler error in last commit on wifi

Bug 2114 - Compiler error in last commit on wifi


Summary:	Compiler error in last commit on wifi

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	wifi
Version:	pre-release
Hardware:	PC Linux

Importance:	P5 major
Assigned To:	sebastien.deronne

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2015-05-05 08:52 UTC by natale.patriciello
Modified:	2015-05-06 16:30 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description natale.patriciello 2015-05-05 08:52:06 UTC

Hi, commit which resolv Bug 2075 gives me this error:

../src/wifi/model/mac-low.cc: In member function ‘void ns3::MacLow::SendDataAfterCts(ns3::Mac48Address, ns3::Time, ns3::WifiMode)’:
../src/wifi/model/mac-low.cc:2001:22: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
     for(int i = 0; i < m_txPackets.size(); i++)
                      ^
cc1plus: all warnings being treated as errors


"int i" should be replaced with unsigned int, or even better uint32_t.

Comment 1 sebastien.deronne 2015-05-05 08:57:40 UTC

Indeed, uint32_t should be used here, sorry for the typo.
I will fix this in a new changeset in few hours.
Thanks for reporting.

Comment 2 sebastien.deronne 2015-05-05 09:08:03 UTC

It seems to have been already fixed by Tom in changeset 11360:b2777e7f5653.
Could you confirm the warning issue has gone?

Comment 3 natale.patriciello 2015-05-05 09:48:22 UTC

Maybe I'm little behind, because I'm using the git mirror... I'll wait the sync between the repos.

Comment 4 sebastien.deronne 2015-05-06 16:30:47 UTC

fixed in changeset 11360:b2777e7f5653