Bug 2115 – The commit "Doxygen config, deprecated, realtime, unused" breaks the build

Bug 2115 - The commit "Doxygen config, deprecated, realtime, unused" breaks the build


Summary:	The commit "Doxygen config, deprecated, realtime, unused" breaks the build

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	core
Version:	pre-release
Hardware:	PC Linux

Importance:	P5 enhancement
Assigned To:	Peter Barnes

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2015-05-05 09:17 UTC by natale.patriciello
Modified:	2015-05-05 12:50 UTC (History)
CC List:	2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description natale.patriciello 2015-05-05 09:17:09 UTC

because the commit commented the functions inherited from SimulatorImpl (a /* and */ mis-placed maybe?)

+  // Inherited from SimulatorImpl
+  /*

  ....

+  */

The errors are:

../src/core/model/realtime-simulator-impl.cc:121:33: error: no ‘void ns3::RealtimeSimulatorImpl::Destroy()’ member function declared in class ‘ns3::RealtimeSimulatorImpl’
 RealtimeSimulatorImpl::Destroy ()
                                 ^
../src/core/model/realtime-simulator-impl.cc:146:68: error: no ‘void ns3::RealtimeSimulatorImpl::SetScheduler(ns3::ObjectFactory)’ member function declared in class ‘ns3::RealtimeSimulatorImpl’
 RealtimeSimulatorImpl::SetScheduler (ObjectFactory schedulerFactory)
                                                                    ^
../src/core/model/realtime-simulator-impl.cc:397:42: error: no ‘bool ns3::RealtimeSimulatorImpl::IsFinished() const’ member function declared in class ‘ns3::RealtimeSimulatorImpl’
 RealtimeSimulatorImpl::IsFinished (void) const

(.. and many other)

Comment 1 Tom Henderson 2015-05-05 09:29:46 UTC

I already took out that comment to fix the build; I'll leave it to Peter to review now to see if more needs to be done.

Comment 2 Peter Barnes 2015-05-05 12:50:50 UTC

Whoops.  Don't know what I was thinking.