Bug 219 - Ipv4Interface is a poor API
Ipv4Interface is a poor API
Status: RESOLVED FIXED
Product: ns-3
Classification: Unclassified
Component: network
pre-release
All All
: P2 normal
Assigned To: Tom Henderson
:
Depends on:
Blocks: 384
  Show dependency treegraph
 
Reported: 2008-06-11 20:00 UTC by Craig Dowell
Modified: 2009-05-29 17:39 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Dowell 2008-06-11 20:00:44 UTC
Ipv4.h has inconsistent method naming and misleading or duplicated method names.  Related problem with Ipv4RoutingProtocol.

Some methods named Find This or That and return uint32 index.
Some methods named Get This or that and return uint32 index.
Some methods take an index for an Ipv4Interface called i.
Some methods take an index for an Ipv4Interface called ifIndex.
Some methods take an index for an Ipv4Interface called interface.

IfIndex is an overloaded term and shouldn't appear here.

Some methods are misleading.  FindIfIndexForDevice implies there is only one interface allowed per device.

Some methods are duplicated?  FindInterfaceForAddr, GetIfIndexByAddress.

This is not very pretty.
Comment 1 Tom Henderson 2009-02-16 01:02:16 UTC
sliding to ns-3.5
Comment 2 Tom Henderson 2009-05-29 17:39:19 UTC
changeset e20a31541404