Bug 2194 – suggest to add ATTR_GET to WifiRemoteStationManager::IsLowLatency attribute

Bug 2194 - suggest to add ATTR_GET to WifiRemoteStationManager::IsLowLatency attribute


Summary:	suggest to add ATTR_GET to WifiRemoteStationManager::IsLowLatency attribute

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	wifi
Version:	unspecified
Hardware:	All All

Importance:	P5 normal
Assigned To:	sebastien.deronne

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2015-10-12 12:17 UTC by Tom Henderson
Modified:	2015-10-30 20:50 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tom Henderson 2015-10-12 12:17:57 UTC

The following attribute of WifiRemoteStationManager is inoperative and misleading; suggest to remove it.    


.AddAttribute ("IsLowLatency", "If true, we attempt to modelize a so-called low-latency device: a device"
                   " where decisions about tx parameters can be made on a per-packet basis and feedback about the"
                   " transmission of each packet is obtained before sending the next. Otherwise, we modelize a "
                   " high-latency device, that is a device where we cannot update our decision about tx parameters"
                   " after every packet transmission.",
                   BooleanValue (true), //this value is ignored because there is no setter
                   MakeBooleanAccessor (&WifiRemoteStationManager::IsLowLatency),
                   MakeBooleanChecker ())

Perhaps move the documentation string to the doxygen of WifiRemoteStationManager::IsLowLatency()

Comment 1 Tom Henderson 2015-10-12 12:25:58 UTC

(In reply to Tom Henderson from comment #0)
> The following attribute of WifiRemoteStationManager is inoperative and
> misleading; suggest to remove it.    
> 

Actually, my mistake; I see how it works now, but it should instead use the 
                   TypeId::ATTR_GET,
flag to preclude set operations.

See e.g. WaypointMobilityModel

   .AddAttribute ("WaypointsLeft", "The number of waypoints remaining.",
                   TypeId::ATTR_GET,
                   UintegerValue (0),
                   MakeUintegerAccessor (&WaypointMobilityModel::WaypointsLeft),
                   MakeUintegerChecker<uint32_t> ())

Comment 2 sebastien.deronne 2015-10-12 13:04:03 UTC

Tom, I agree to change it as suggested.

Comment 3 Tom Henderson 2015-10-30 20:50:23 UTC

fixed in changeset 11744:d6a6751315f9