Bug 2259 – GSL not successfully enabled for WiFi DSSS error rate model

Bug 2259 - GSL not successfully enabled for WiFi DSSS error rate model


Summary:	GSL not successfully enabled for WiFi DSSS error rate model

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	wifi
Version:	pre-release
Hardware:	PC Linux

Importance:	P5 normal
Assigned To:	sebastien.deronne

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2016-01-12 11:16 UTC by Tom Henderson
Modified:	2016-01-14 17:36 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
patch to fix (2.11 KB, patch) 2016-01-12 11:16 UTC, Tom Henderson	Details \| Diff
regression test (15.69 KB, patch) 2016-01-12 19:47 UTC, Tom Henderson	Details \| Diff
test program from validation document (7.46 KB, text/x-csrc) 2016-01-12 20:05 UTC, Tom Henderson	Details
plotting program (1.75 KB, text/plain) 2016-01-12 20:06 UTC, Tom Henderson	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tom Henderson 2016-01-12 11:16:34 UTC

Created attachment 2227 [details]
patch to fix

Even if a platform has GSL installed, the preprocesser defines are wrong in the code, causing the non-GSL code to execute in all cases.

Attached patch fixes the problem (ENABLE_* at configure time is changed to HAVE_* at build time).

Will write a regression test for this before closing out.

Comment 1 Tom Henderson 2016-01-12 19:47:26 UTC

Created attachment 2228 [details]
regression test

regression test attached

Comment 2 Tom Henderson 2016-01-12 20:05:58 UTC

Created attachment 2231 [details]
test program from validation document

The DSSS error rate program and plotting script could also be possibly added to the src/wifi/test directory.  I scraped it out of the PDF, reformatted, added GPL, and attach it here.

Comment 3 Tom Henderson 2016-01-12 20:06:28 UTC

Created attachment 2232 [details]
plotting program

The DSSS error rate program and plotting script could also be possibly added to the src/wifi/test directory.  I scraped it out of the PDF, reformatted, added GPL, and attach it here.

Comment 4 sebastien.deronne 2016-01-13 16:57:38 UTC

I had a quick look, I am in favor to deliver those changes.
Utests were indeed missing (as for a lot of other parts of the code, that I plan to cover as much as possible in the future), so this is a really nice-to-have.

Comment 5 Tom Henderson 2016-01-14 17:36:40 UTC

bugfix pushed in changeset 11817:908a1df3879d

test programs pushed in changeset 11818:1df885710050