Bug 2267 – Wrong channel bandwidth value in pcap files

Bug 2267 - Wrong channel bandwidth value in pcap files


Summary:	Wrong channel bandwidth value in pcap files

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	wifi
Version:	pre-release
Hardware:	All All

Importance:	P5 minor
Assigned To:	sebastien.deronne

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2016-01-15 23:37 UTC by P
Modified:	2016-01-16 06:12 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
fix for bug 2267 (4.45 KB, patch) 2016-01-16 06:06 UTC, sebastien.deronne	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description P 2016-01-15 23:37:19 UTC

I found txVector.GetChannelWidth() has return value in MHz units. but yans-wifi-helper.cc use in Hz units.

for example.

if (txVector.GetChannelWidth () == 40000000)
    {
                mcsFlags |= RadiotapHeader::MCS_FLAGS_BANDWIDTH_40;
    }

Comment 1 sebastien.deronne 2016-01-16 05:47:42 UTC

It looks indeed not correct.

When implementing 802.11ac, I had originally chosen for getting the bandwidth in Hz, but then I went back to Mhz units. Apparently that part of the code was forgotten to be adapted. I will test and prepare a fix today.

Comment 2 sebastien.deronne 2016-01-16 06:06:27 UTC

Created attachment 2238 [details]
fix for bug 2267

I added a fix for this bug.
Since it is an obvious one, I will deliver it in ns-3-dev immediately.
Thanks for reporting!

Comment 3 sebastien.deronne 2016-01-16 06:12:37 UTC

pushed in 11821:2965f0748903