Bugzilla – Bug 2317
Get the non-HT reference rate of a HT MCS
Last modified: 2016-03-09 16:01:07 UTC
Created attachment 2314 [details] Add GetNonHtReferenceRate In some situations (like sending an RTS in a non-HT PPDU), converting an HT MCS to a non-HT rate is needed. For this, the standard defines the "reference rates" and offers a table for the conversion. The patch attached adds a function for this conversion.
What about Erp Ofdm?
(In reply to sebastien.deronne from comment #1) > What about Erp Ofdm? Hi Sebastien. I don't understand what your are asking about?
(In reply to Matías Richart from comment #2) > (In reply to sebastien.deronne from comment #1) > > What about Erp Ofdm? > > Hi Sebastien. I don't understand what your are asking about? Your change is ok for 5GHz channel, but not for 802.11n operating at 2.4GHz. I.e. "OfdmRate6Mbps" refers to 802.11a, but you should consider "ErpOfdmRate6Mbps" which refers to 802.11g.
(In reply to sebastien.deronne from comment #3) > (In reply to Matías Richart from comment #2) > > (In reply to sebastien.deronne from comment #1) > > > What about Erp Ofdm? > > > > Hi Sebastien. I don't understand what your are asking about? > > Your change is ok for 5GHz channel, but not for 802.11n operating at 2.4GHz. > > I.e. "OfdmRate6Mbps" refers to 802.11a, but you should consider > "ErpOfdmRate6Mbps" which refers to 802.11g. Ok, I understand. I check the standard and the reference rate is always used to compare data rates. For example, "selecting a rate from the basicRateSet which is less or equal to the non-HT reference rate". Then, what do you think of returning an integer with the data rate instead of the WifiMode? So as to avoid asking for the frequency.
(In reply to Matías Richart from comment #4) > (In reply to sebastien.deronne from comment #3) > > (In reply to Matías Richart from comment #2) > > > (In reply to sebastien.deronne from comment #1) > > > > What about Erp Ofdm? > > > > > > Hi Sebastien. I don't understand what your are asking about? > > > > Your change is ok for 5GHz channel, but not for 802.11n operating at 2.4GHz. > > > > I.e. "OfdmRate6Mbps" refers to 802.11a, but you should consider > > "ErpOfdmRate6Mbps" which refers to 802.11g. > > Ok, I understand. > > I check the standard and the reference rate is always used to compare data > rates. For example, "selecting a rate from the basicRateSet which is less or > equal to the non-HT reference rate". > Then, what do you think of returning an integer with the data rate instead > of the WifiMode? > So as to avoid asking for the frequency. It actually depends on how it will be used (WifiMode contains more information than a rate), but if the rate looks enough then we can go for it.
Created attachment 2332 [details] New patch, returns data rate instead of WifiMode
The Doxygen is not up to date with the code changes. Does passing the argument 'nss' make any difference? Could the 'nss' be hardcoded to 1 within this method?
(In reply to Tom Henderson from comment #7) > The Doxygen is not up to date with the code changes. > > Does passing the argument 'nss' make any difference? Could the 'nss' be > hardcoded to 1 within this method? I need the nss to call WifiMode::GetCodeRate. However, in GetCodeRate the nss is just used for checking in an assert. A hardcoded value of 1 will not work.
Created attachment 2333 [details] New patch, returns data rate instead of WifiMode. Doxygen corrected
pushed in changeset 12000:d600a963e02e