Bug 2321 – Wifi rate managers should not be triggered for each MPDU when A-MPDU is used

Bug 2321 - Wifi rate managers should not be triggered for each MPDU when A-MPDU is used


Summary:	Wifi rate managers should not be triggered for each MPDU when A-MPDU is used

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	wifi
Version:	ns-3-dev
Hardware:	All All

Importance:	P5 enhancement
Assigned To:	sebastien.deronne

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2016-03-02 17:10 UTC by sebastien.deronne
Modified:	2016-03-09 15:57 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
Patch to fix backward compatibility (11.89 KB, patch) 2016-03-02 17:10 UTC, sebastien.deronne	Details \| Diff
patch to fix (11.89 KB, patch) 2016-03-02 17:10 UTC, sebastien.deronne	Details \| Diff
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description sebastien.deronne 2016-03-02 17:10:03 UTC

Created attachment 2322 [details]
Patch to fix backward compatibility

When MPDU aggregation is used, ReportDataOK or ReportDataFailed is called for each received or lost MPDUs, respectively.  This makes actually not sense, unless we specify its number of retries. 

Instead, we should handle this in the BlockAckManager itself, and only trigger once the wifi rate manager each time a block ack is received or lost, with information about the number of failed and successful MPDUs. See patch in attachment.

Those changes are required to support HT Minstrel.

Comment 1 sebastien.deronne 2016-03-02 17:10:48 UTC

Created attachment 2323 [details]
patch to fix

Comment 2 sebastien.deronne 2016-03-09 15:57:40 UTC

changeset 11996:4cb82703d8cb