Bug 2337 – WifiPhy uses channel width in Hz iso MHz

Bug 2337 - WifiPhy uses channel width in Hz iso MHz


Summary:	WifiPhy uses channel width in Hz iso MHz

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	wifi
Version:	pre-release
Hardware:	All All

Importance:	P2 major
Assigned To:	sebastien.deronne

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2016-03-15 13:40 UTC by Ali Rostami
Modified:	2016-03-15 19:28 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
Suggested Patch (569 bytes, patch) 2016-03-15 13:40 UTC, Ali Rostami	Details \| Diff
extend Ali's patch (3.25 KB, patch) 2016-03-15 17:36 UTC, sebastien.deronne	Details \| Diff
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ali Rostami 2016-03-15 13:40:39 UTC

Created attachment 2340 [details]
Suggested Patch

Hey All,

I was playing with the different PhyModes to understand the ns3 approach to handling different bandwidths (20MHz, 10MHz, 5MHz), noticed the values for the switch haven't been updated to 20, 10, and 5.

switch (txVector.GetChannelWidth ())
          {
          case 20000000:
          default:
            symbolDuration = MicroSeconds (4);
            break;
          case 10000000:
            symbolDuration = MicroSeconds (8);
            break;
          case 5000000:
            symbolDuration = MicroSeconds (16);
            break;
          }

Please see the attachment for suggested patch.
-Ali

Comment 1 sebastien.deronne 2016-03-15 17:36:52 UTC

Created attachment 2341 [details]
extend Ali's patch

Ali, thanks.

I extended a bit your patch since there are other places where channel width is used in Hz iso MHz.

Comment 2 sebastien.deronne 2016-03-15 17:37:43 UTC

I will check with Tom whether it is still possible to deliver this fix for ns-3.25.

Comment 3 Ali Rostami 2016-03-15 18:52:04 UTC

(In reply to sebastien.deronne from comment #2)
> I will check with Tom whether it is still possible to deliver this fix for
> ns-3.25.

Thanks, Sebastien. Sounds good to me.

Comment 4 sebastien.deronne 2016-03-15 19:28:56 UTC

pushed in changeset 12050:589b138eb7f6