Bug 2420 - Remove code duplication between Wifi and Wave modules
Remove code duplication between Wifi and Wave modules
Status: RESOLVED FIXED
Product: ns-3
Classification: Unclassified
Component: wifi
unspecified
All All
: P5 enhancement
Assigned To: sebastien.deronne
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2016-05-21 16:59 UTC by sebastien.deronne
Modified: 2016-06-10 16:15 UTC (History)
1 user (show)

See Also:


Attachments
patch to remove code duplication (17.51 KB, patch)
2016-05-21 17:01 UTC, sebastien.deronne
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description sebastien.deronne 2016-05-21 16:59:54 UTC
Wifi and Wave define exactly same functions to handle pcap files, which should definitely be avoided.
Comment 1 sebastien.deronne 2016-05-21 17:01:14 UTC
Created attachment 2446 [details]
patch to remove code duplication
Comment 2 sebastien.deronne 2016-06-04 06:46:49 UTC
Setting to LAST CALL, it is a quite obvious enhancement.
Comment 3 sebastien.deronne 2016-06-10 16:15:20 UTC
pushed in changeset 12155:ee71da343b3e