Bug 2448 - missing examples-to-run.py
missing examples-to-run.py
Status: RESOLVED FIXED
Product: ns-3
Classification: Unclassified
Component: traffic-control
unspecified
All All
: P5 normal
Assigned To: Mohit
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2016-06-22 21:05 UTC by Tom Henderson
Modified: 2016-06-29 12:33 UTC (History)
3 users (show)

See Also:


Attachments
Proposed examples-to-run.py (825 bytes, text/plain)
2016-06-23 12:46 UTC, Stefano Avallone
Details
Modified examples-to-run.py (2.22 KB, text/x-python-script)
2016-06-23 13:44 UTC, Mohit
Details
Final examples-to-run.py (2.22 KB, text/x-python-script)
2016-06-23 17:05 UTC, Mohit
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Henderson 2016-06-22 21:05:12 UTC
when queue discs moved from src/network to src/traffic-control, they stopped being run in the test suite.  We need a new src/traffic-control/test/examples-to-run.py restoring these tests.
Comment 1 Stefano Avallone 2016-06-23 12:46:20 UTC
Created attachment 2479 [details]
Proposed examples-to-run.py

Are you fine with committing the attached file? I checked that all the traffic-control examples are run by test.py (and pass).
Comment 2 Tom Henderson 2016-06-23 12:49:47 UTC
Yes, no need to wait on this; thanks for handling.
Comment 3 Mohit 2016-06-23 12:51:46 UTC
I have made almost the same file, but with different command line arguments for every program that has them.

I will upload the same here in a while, I'm checking whether it works fine with test.py.

Thanks
Comment 4 Mohit 2016-06-23 13:44:10 UTC
Created attachment 2480 [details]
Modified examples-to-run.py

I have attached a modified examples-to-run.py which checks every example against different command line arguments.

All the tests passed with test.py
Comment 5 Mohit 2016-06-23 17:05:23 UTC
Created attachment 2482 [details]
Final examples-to-run.py

There was a missing "-" in the previous file.

Corrected that in the latest one.

- Mohit
Comment 6 Stefano Avallone 2016-06-29 12:33:24 UTC
Pushed with changeset 12173.