Bug 2456 – Add MemberCschedSapProvider and MemberCschedSapProvider

Bug 2456 - Add MemberCschedSapProvider and MemberCschedSapProvider


Summary:	Add MemberCschedSapProvider and MemberCschedSapProvider

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	lte
Version:	ns-3-dev
Hardware:	All All

Importance:	P5 enhancement
Assigned To:	Biljana Bojović

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2016-07-29 19:00 UTC by Alexander Krotov
Modified:	2016-10-19 09:24 UTC (History)
CC List:	3 users (show)

See Also:

Attachments
Proposed patch (78.45 KB, patch) 2016-07-29 19:00 UTC, Alexander Krotov	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alexander Krotov 2016-07-29 19:00:20 UTC

Created attachment 2503 [details]
Proposed patch

LTE schedulers have lots of code duplication. To reduce code size a bit I added templates to ff-mac-csched-sap.h and ff-mac-sched-sap.h similar to already implemented in lte-rrc-sap.h, lte-ue-cphy-sap.h and others. Patch is attached.

Comment 1 Biljana Bojović 2016-10-19 09:04:28 UTC

Hi,

I spoke with Marco few days ago about this patch and he is fine with it. I also reviewed the patch and tested it with the latest ns-3-dev and all works fine. I think is a great work.

So I think you should go ahead and commit it.

Thank you for contributing the code!

Biljana

Comment 2 Alexander Krotov 2016-10-19 09:24:30 UTC

Pushed in changeset bae1951064d2