Bug 2491 – replace DcfManager::MY_DEBUG

Bug 2491 - replace DcfManager::MY_DEBUG


Summary:	replace DcfManager::MY_DEBUG

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	wifi
Version:	unspecified
Hardware:	All All

Importance:	P5 enhancement
Assigned To:	sebastien.deronne

URL:
Keywords:

Depends on:	2490
Blocks:
	Show dependency tree / graph

Reported:	2016-09-06 15:21 UTC by Tom Henderson
Modified:	2017-01-23 15:12 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
reworked logs of DcfManager and additional logs for DcfState (7.74 KB, patch) 2016-10-15 15:37 UTC, sebastien.deronne	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tom Henderson 2016-09-06 15:21:01 UTC

dcf-manager.cc still contains a MY_DEBUG() macro that predates the ns-3 logging infrastructure.  However, I do not want to replace with NS_LOG_DEBUG statements until bug 2490 is resolved since the current MY_DEBUG () provides nanosecond time resolution on those debug events.

More logging in class DcfState could also be added.

Comment 1 sebastien.deronne 2016-10-15 11:13:05 UTC

Tom, can't we already provide a patch for this?
When is bug 2490 supposed to be addressed?

Comment 2 Tom Henderson 2016-10-15 14:19:31 UTC

(In reply to sebastien.deronne from comment #1)
> Tom, can't we already provide a patch for this?
> When is bug 2490 supposed to be addressed?

No one has commented on 2490, so I will provide a patch this weekend based on what I outlined there, and we can move forward with this one after that is committed.

I agree, the patch for dcf-manager.cc can be prepared in parallel.

Comment 3 sebastien.deronne 2016-10-15 15:37:49 UTC

Created attachment 2618 [details]
reworked logs of DcfManager and additional logs for DcfState

Tom, here is already the patch for this.

Comment 4 sebastien.deronne 2016-11-23 16:57:24 UTC

To be pushed once bug 2490 is delivered

Comment 5 sebastien.deronne 2017-01-23 15:12:32 UTC

Pushed in changeset 12561:a5af139f97f3