Bug 2512 – Byte mode not configured correctly in red-queue-disc-test-suite.cc

Bug 2512 - Byte mode not configured correctly in red-queue-disc-test-suite.cc


Summary:	Byte mode not configured correctly in red-queue-disc-test-suite.cc

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	traffic-control
Version:	ns-3-dev
Hardware:	All All

Importance:	P5 enhancement
Assigned To:	Stefano Avallone

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2016-09-29 16:18 UTC by Mohit
Modified:	2017-01-09 14:11 UTC (History)
CC List:	2 users (show)

See Also:

Attachments
red-byte-mode.patch (619 bytes, patch) 2016-09-29 16:18 UTC, Mohit	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mohit 2016-09-29 16:18:11 UTC

Created attachment 2598 [details]
red-byte-mode.patch

In red-queue-disc-test-suite.cc, there is a large difference in the number of packet drops when run in byte mode and packet mode.

This is because the MeanPktSize in RED is 500 bytes by default, whereas the test suite uses a pktSize of 1000 bytes.

The patch provided here addresses the issue by configuring test suite to use pktSize of 500 bytes.

Thanks,
Mohit P. Tahiliani

Comment 1 Tom Henderson 2016-10-06 09:31:49 UTC

Moving to 'LAST CALL'; will commit sometime soon if no comments.

Comment 2 Stefano Avallone 2017-01-09 14:11:35 UTC

Fixed by changeset 12521:7c23e2de62af, thanks!