Bug 2541 – preamble not assigned correctly

Bug 2541 - preamble not assigned correctly


Summary:	preamble not assigned correctly

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	wifi
Version:	ns-3.26
Hardware:	All All

Importance:	P5 major
Assigned To:	sebastien.deronne

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2016-11-06 06:03 UTC by natale.patriciello
Modified:	2016-11-07 17:11 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
patch (864 bytes, patch) 2016-11-06 06:03 UTC, natale.patriciello	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description natale.patriciello 2016-11-06 06:03:14 UTC

Created attachment 2659 [details]
patch

Very subtle bug, discovered by static analysis. In practice, the preamble is wrong. If the not-patched version is the desidered behaviour, the first if could be removed.

Comment 1 sebastien.deronne 2016-11-06 06:05:15 UTC

+1, should be dropped asap.
Thanks Natale!

Comment 2 sebastien.deronne 2016-11-06 06:08:07 UTC

Note that this bug will be anyway cleared soon because I am refactoring the code to move preamble to txvector, I will open a new thread for that. But this patch could anyway be pushed in the meantime to ns-3-dev.

Comment 3 sebastien.deronne 2016-11-07 17:11:48 UTC

changeset 12393:c44c7f1a740e