Bug 2560 – Uplink harqProcessId update

Bug 2560 - Uplink harqProcessId update


Summary:	Uplink harqProcessId update

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	lte
Version:	ns-3.26
Hardware:	PC Linux

Importance:	P5 normal
Assigned To:	Biljana Bojović

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2016-11-21 21:48 UTC by plyang123
Modified:	2017-12-21 17:48 UTC (History)
CC List:	4 users (show)

See Also:

Attachments
proposed patch (390 bytes, patch) 2017-01-12 20:25 UTC, plyang123	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description plyang123 2016-11-21 21:48:08 UTC

In LteUeMac::DoSubframeIndication() 
harqProcessId is only updated when bsr is freshed. That would lead to rlcPdu going into the wrong harq buffer. Once retx happens, wrong rlcPdu is sent.




I suppose it should be updated every subframe.

Comment 1 Biljana Bojović 2016-11-22 14:49:21 UTC

Hi Yang, 

do you refer to ns-3-dev code or to ns-3-lbt code?

Thanks,
Biljana

Comment 2 plyang123 2016-11-22 19:08:46 UTC

(In reply to Biljana Bojović from comment #1)
> Hi Yang, 
> 
> do you refer to ns-3-dev code or to ns-3-lbt code?
> 
> Thanks,
> Biljana

Oh, yes. I refer to ns-3-lbt. Should I choose version ns-3-dev?

Comment 3 Biljana Bojović 2017-01-12 12:11:11 UTC

Hi Yang, 

thank you very much for pointing out the issue. I took a look but I am still not sure what exactly is the problem, and is it only detected in LBT code or also in ns-3-dev. Do you have maybe a patch for this? If you have any other information, example program, some traces, it would be useful.

Thanks,
Biljana

Comment 4 plyang123 2017-01-12 20:25:33 UTC

Created attachment 2745 [details]
proposed patch

Comment 5 plyang123 2017-01-12 20:30:14 UTC

(In reply to Biljana Bojović from comment #3)
> Hi Yang, 
> 
> thank you very much for pointing out the issue. I took a look but I am still
> not sure what exactly is the problem, and is it only detected in LBT code or
> also in ns-3-dev. Do you have maybe a patch for this? If you have any other
> information, example program, some traces, it would be useful.
> 
> Thanks,
> Biljana

Hi Biljana,
   I have uploaded a proposed patch. I run some uplink traffic, and the original version can not get all 354 packets received even though the few nacks are retransmitted successfully. Then I check the log and find that a successfully received pdu is retransmitted which is because the wrong pdu is taken out. After doing the above patch, the problem is solved.

Comment 6 Zoraze Ali 2017-12-21 17:48:41 UTC

The bug is resolved in this bug report: https://www.nsnam.org/bugzilla/﷒0﷓. 

We can close this one as well. 

Kind regards, 
Zoraze