Bug 2568 – Avoid enumerating TCP variants in examples

Bug 2568 - Avoid enumerating TCP variants in examples


Summary:	Avoid enumerating TCP variants in examples

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	examples
Version:	ns-3-dev
Hardware:	All All

Importance:	P3 enhancement
Assigned To:	ns-bugs

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2016-12-04 14:12 UTC by Rohit P. Tahiliani
Modified:	2017-06-03 01:45 UTC (History)
CC List:	1 user (show)

See Also:

Attachments
Proposed patch (6.15 KB, patch) 2016-12-04 14:12 UTC, Rohit P. Tahiliani	Details \| Diff
Proposed patch (6.31 KB, patch) 2017-05-30 14:38 UTC, Rohit P. Tahiliani	Details \| Diff
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Rohit P. Tahiliani 2016-12-04 14:12:20 UTC

Created attachment 2690 [details]
Proposed patch

As suggested by Tom Sir, I have attached a patch that makes use of

TypeId::LookupByNameFailSafe (std::string name, TypeId *tid)

in examples/tcp/tcp-variants-comparison.cc to avoid enumerating all TCP variants.

I will see if I can find more such programs which enumerate TCP variants, and update them. I did not find more in examples/tcp directory.

Any suggestions would be much appreciated.

Thanks,
Rohit P. Tahiliani

Comment 1 Rohit P. Tahiliani 2017-05-30 14:38:03 UTC

Created attachment 2856 [details]
Proposed patch

Comment 2 Rohit P. Tahiliani 2017-05-30 14:39:12 UTC

Hi Tom Sir,

I have uploaded a new patch based on the latest ns-3-dev. 

Thank you,
Rohit

Comment 3 Tom Henderson 2017-06-03 01:45:36 UTC

committed in changeset 12907:86f643f3d027