Bug 2577 – simulation crashes when A-MPDU and multiple TOS are used with RTS-CTS enabled

Bug 2577 - simulation crashes when A-MPDU and multiple TOS are used with RTS-CTS enabled


Summary:	simulation crashes when A-MPDU and multiple TOS are used with RTS-CTS enabled

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	wifi
Version:	ns-3-dev
Hardware:	All All

Importance:	P3 major
Assigned To:	sebastien.deronne

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2016-12-09 14:52 UTC by sebastien.deronne
Modified:	2017-01-02 02:47 UTC (History)
CC List:	2 users (show)

See Also:

Attachments
simulation script to reproduce the issue (6.92 KB, text/x-csrc) 2016-12-09 14:52 UTC, sebastien.deronne	Details
proposed patch to fix (17.20 KB, patch) 2016-12-09 14:54 UTC, sebastien.deronne	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description sebastien.deronne 2016-12-09 14:52:12 UTC

Created attachment 2696 [details]
simulation script to reproduce the issue

Changeset 12439:c0fdcce4fd59 fixed bug 2564 in case A-MPDU is used with RTS-CTS enabled. If we consider a similar scenario but with multiple TOS, the assert seen in bug 2564 is indeed no longer observed, but simulation does crash instead. Test script is provided in attachment, and was reported on the forum:
https://groups.google.com/forum/#!topic/ns-3-users/BhTjv7u66vQ

Comment 1 sebastien.deronne 2016-12-09 14:54:21 UTC

Created attachment 2697 [details]
proposed patch to fix

Comment 2 sebastien.deronne 2016-12-09 14:54:57 UTC

(In reply to sebastien.deronne from comment #1)
> Created attachment 2697 [details]
> proposed patch to fix

Patch does add support for multiple TOS scenarios.

Comment 3 sebastien.deronne 2016-12-18 08:53:41 UTC

I'd like to push the fix before next weekend

Comment 4 Tom Henderson 2016-12-20 00:51:19 UTC

(In reply to sebastien.deronne from comment #3)
> I'd like to push the fix before next weekend

Patch looks OK, but can the test be extended to cover the TOS scenario also?

Comment 5 sebastien.deronne 2016-12-21 15:49:03 UTC

(In reply to Tom Henderson from comment #4)
> (In reply to sebastien.deronne from comment #3)
> > I'd like to push the fix before next weekend
> 
> Patch looks OK, but can the test be extended to cover the TOS scenario also?

I will give a try.

Comment 6 sebastien.deronne 2017-01-02 02:47:25 UTC

Fix pushed in changeset 12512:844a94b3ee97 and added an example in changeset 12513:3d2af176509f