Bug 2588 – PER model should be improved

Bug 2588 - PER model should be improved


Summary:	PER model should be improved

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	uan
Version:	ns-3-dev
Hardware:	All All

Importance:	P3 normal
Assigned To:	Federico Guerra

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2016-12-15 09:32 UTC by Federico Guerra
Modified:	2017-08-17 11:21 UTC (History)
CC List:	2 users (show)

See Also:

Attachments
proposed new model (11.92 KB, patch) 2017-03-19 05:19 UTC, Federico Guerra	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Federico Guerra 2016-12-15 09:32:04 UTC

Currently UAN supports:
- FH-FSK PER model for micro modem
- a simple threshold PER model.

This is not enough for an accurate simulation.

Proposed improvement:
- micro modem should only support FSK as UanTxMode
- micro modem's PER class should check that the input UanTxMode is compatible
- a new PER model should be devised in order to compute PER from BER, taking into account the current UanTxMode.

Comment 1 Federico Guerra 2016-12-15 09:32:38 UTC

fix already partially developed, patch to follow.

Comment 2 Federico Guerra 2017-03-19 05:19:58 UTC

Created attachment 2807 [details]
proposed new model

a new PER calculator class has been added in order to support standard PER computations.

stricter check has been also enforced on other PER calculations. A fatal error will be thrown in case of incompatible tx mode and PER calculator.

Comment 3 Federico Guerra 2017-03-19 05:21:29 UTC

Tom, the patch has been reviewed by external UAN users.
Let me know if you require me to change anything.
thanks

Comment 4 Tom Henderson 2017-08-17 11:21:28 UTC

committed in changeset 13046:148275861a43