Bug 2597 – code review: wifi code refactoring phase 1

Bug 2597 - code review: wifi code refactoring phase 1


Summary:	code review: wifi code refactoring phase 1

Status:	RESOLVED FIXED

Product:	ns-3
Classification:	Unclassified
Component:	wifi
Version:	pre-release
Hardware:	All All

Importance:	P3 enhancement
Assigned To:	sebastien.deronne

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2016-12-24 06:31 UTC by sebastien.deronne
Modified:	2017-01-25 15:15 UTC (History)
CC List:	2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description sebastien.deronne 2016-12-24 06:31:37 UTC

This first phase is mainly targeting to remove code duplication and keep one class per file to avoid large files.

https://codereview.appspot.com/311400043/

Comment 1 sebastien.deronne 2016-12-24 06:33:32 UTC

Review sent some time ago already. Since I will already suffer a lot of merge conflicts and it will get even worse, I suggest to push those changes to ns-3-dev asap. 
Tom, could you maybe have a quick look? 
All tests are passing, there is no functionality changes.

Comment 2 Tom Henderson 2016-12-24 10:28:36 UTC

comments provided in review issue

Comment 3 sebastien.deronne 2016-12-24 10:30:32 UTC

(In reply to Tom Henderson from comment #2)
> comments provided in review issue

Thanks a lot for your prompt reaction :-)
Since I am soon gone for the rest of the weekend, I'll handle your comments next week.

Comment 4 sebastien.deronne 2017-01-05 12:49:34 UTC

Review updated with new patch set handling Tom's comments and removing listeners

Comment 5 sebastien.deronne 2017-01-18 13:11:04 UTC

Are there any remaining comments on the latest patch set?
If not I suggest to deliver those changes by the end of the week.

Comment 6 sebastien.deronne 2017-01-22 15:30:22 UTC

Patch set updated to address Tom's comments.
I think patch is ready to be pushed.

Comment 7 sebastien.deronne 2017-01-23 15:18:00 UTC

If no further comments, I suggest to deliver those changes by Wednesday.

Comment 8 sebastien.deronne 2017-01-25 15:15:20 UTC

changeset 12571:80142e260133