Bugzilla – Bug 2660
TrafficControlHelper::Default should not configure internal queue sizes
Last modified: 2017-02-24 08:43:07 UTC
Use of the TrafficControlHelper::Default() method will apply a pfifo_fast qdisc with 1000 packet depth in each band. However, if user tries to configure the default value for PfifoFastQueueDisc::MaxPackets, it will not get applied, and the CheckConfig() method will report an error if the MaxPackets value exceeds 1000. The solution is simple; allow CheckConfig() to instantiate the internal queues, and assign MaxPackets there. --- a/src/traffic-control/helper/traffic-control-helper.cc +++ b/src/traffic-control/helper/traffic-control-helper.cc @@ -110,8 +110,7 @@ TrafficControlHelper TrafficControlHelper::Default (void) { TrafficControlHelper helper; - uint16_t handle = helper.SetRootQueueDisc ("ns3::PfifoFastQueueDisc"); - helper.AddInternalQueues (handle, 3, "ns3::DropTailQueue", "MaxPackets", UintegerValue (1000)); + helper.SetRootQueueDisc ("ns3::PfifoFastQueueDisc"); return helper; }
Fixed with changeset 12710:d4e7d5d01670, thanks!